Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest localization for 0.71.x #3922

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Latest localization for 0.71.x #3922

merged 2 commits into from
Nov 8, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Nov 8, 2019

Fixes brave/brave-browser#6821
Fixes brave/brave-browser#6767
Fixes brave/brave-browser#2147

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 0.71.x - Release milestone Nov 8, 2019
@mkarolin mkarolin self-assigned this Nov 8, 2019
@mkarolin mkarolin added the CI/skip Do not run CI builds (except noplatform) label Nov 8, 2019
@@ -2050,6 +2070,7 @@ Keep your key file in a safe place. You will need it to create new versions of y
<translation id="2650609753175229582"><ph name="URL"/> wants to play protected content. Your device's identity will be verified by Brave Software and may be accessed by this site.</translation>
<translation id="1746402432151920942">Protected media identifier</translation>
<translation id="1322046419516468189">View and manage saved passwords in your <ph name="SAVED_PASSWORDS_STORE"/></translation>
<translation id="3312599731068160560">https://passwords.google.com</translation>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this string showing up?

Copy link
Collaborator Author

@mkarolin mkarolin Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string is IDS_PASSWORDS_WEB_LINK. Only see it in
chrome/browser/android/password_ui_view_android.cc:221
PasswordUIView_GetAccountDashboardURL

@NejcZdovc NejcZdovc removed their request for review November 8, 2019 12:36
@mkarolin mkarolin removed the CI/skip Do not run CI builds (except noplatform) label Nov 8, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants