-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest localization for 0.71.x #3922
Conversation
b9fe3ba
to
a6d9c04
Compare
@@ -2050,6 +2070,7 @@ Keep your key file in a safe place. You will need it to create new versions of y | |||
<translation id="2650609753175229582"><ph name="URL"/> wants to play protected content. Your device's identity will be verified by Brave Software and may be accessed by this site.</translation> | |||
<translation id="1746402432151920942">Protected media identifier</translation> | |||
<translation id="1322046419516468189">View and manage saved passwords in your <ph name="SAVED_PASSWORDS_STORE"/></translation> | |||
<translation id="3312599731068160560">https://passwords.google.com</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this string showing up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string is IDS_PASSWORDS_WEB_LINK
. Only see it in
chrome/browser/android/password_ui_view_android.cc:221
PasswordUIView_GetAccountDashboardURL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Fixes brave/brave-browser#6821
Fixes brave/brave-browser#6767
Fixes brave/brave-browser#2147
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.